From 77945f84208cd55612d14d6a0270ebb5b9e8cee7 Mon Sep 17 00:00:00 2001 From: Arne Blumentritt Date: Sun, 25 Apr 2021 19:35:34 +0200 Subject: [PATCH] Fixed #61 Warnings in homebridge 1.3 because of illegal characteristic values --- accessories/neatoVacuumRobot.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/accessories/neatoVacuumRobot.js b/accessories/neatoVacuumRobot.js index c598005..c3b95fd 100644 --- a/accessories/neatoVacuumRobot.js +++ b/accessories/neatoVacuumRobot.js @@ -487,7 +487,7 @@ NeatoVacuumRobotAccessory.prototype = { getSpotClean: function (callback) { - callback(); + callback(false, this.spotCleanService.getCharacteristic(Characteristic.On).value); }, setSpotClean: function (on, callback) @@ -645,8 +645,13 @@ NeatoVacuumRobotAccessory.prototype = { if (this.spotPlusFeatures) { - this.spotCleanService.setCharacteristic(SpotWidthCharacteristic, this.robot.spotWidth); - this.spotCleanService.setCharacteristic(SpotHeightCharacteristic, this.robot.spotHeight); + let widthProps = this.spotCleanService.getCharacteristic(SpotWidthCharacteristic).props; + let heightProps = this.spotCleanService.getCharacteristic(SpotHeightCharacteristic).props; + + this.spotCleanService.setCharacteristic(SpotWidthCharacteristic, + this.robot.spotWidth >= widthProps.minValue && this.robot.spotWidth <= widthProps.maxValue ? this.robot.spotWidth : widthProps.minValue); + this.spotCleanService.setCharacteristic(SpotHeightCharacteristic, + this.robot.spotHeight >= heightProps.minValue && this.robot.spotHeight <= heightProps.maxValue ? this.robot.spotHeight : heightProps.minValue); } }