just drying someting

Add npm shield tag

.github/workflows/npm.yml

@@ -0,0 +1,19 @@
+name: npm
+on:
+  workflow_dispatch:
+  release:
+    types: [created]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    # Setup .npmrc file to publish to npm
+    - uses: actions/setup-node@v2
+      with:
+        node-version: '12.x'
+        registry-url: 'https://registry.npmjs.org'
+    - run: npm install
+    - run: npm publish
+      env:
+        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

CHANGELOG.md

@@ -118,5 +118,18 @@
 ## 0.7.2
 * Fixed homebridge crash with multiple robots per account
 
-## 0.7.3
+## 0.8.0
-* Fixed warnings since homebridge 1.3.0
+* Add German plugin language (for example, this gives you a "Sauge Küche" Siri command for a zone called "Küche")
+* Added possibility to toggle between languages (English/German) in Homebridge UI Plugin Settings
+
+## 0.8.1
+* Include Robot name in Homekit battery service name
+
+## 0.8.2
+* Eliminate warnings on Homebridge >= 1.3.0 (77945f8 and 877c3d7 on `naofireblade/homebridge-neato`)
+
+## 0.8.3
+* Add French plugin language (for example, this gives you a "Aspirer la cuisine" Siri command for a zone called "La cuisine")
+
+## 0.8.4
+* Link to token getter tool in homebridge UI 

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2017 Arne Blumentritt
+Copyright (c) 2020 Luis Riegger
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,15 +1,14 @@
-# homebridge-neato
+[![Latest NPM release](https://img.shields.io/npm/v/homebridge-kobold.svg)](https://www.npmjs.com/package/homebridge-kobold)
-[![npm](https://img.shields.io/npm/v/homebridge-neato)](https://www.npmjs.com/package/homebridge-neato)
+[![NPM Downloads](https://img.shields.io/npm/dt/homebridge-kobold.svg)](https://www.npmjs.com/package/homebridge-kobold?activeTab=versions)
-[![npm](https://img.shields.io/npm/dt/homebridge-neato)](https://www.npmjs.com/package/homebridge-neato?activeTab=versions)
-[![GitHub last commit](https://img.shields.io/github/last-commit/naofireblade/homebridge-neato)](https://github.com/naofireblade/homebridge-neato)
 
-This is a plugin for [homebridge](https://github.com/nfarina/homebridge) to control your [Neato](https://www.neatorobotics.com/) vacuum robot. You can download it via [npm](https://www.npmjs.com/package/homebridge-neato).
 
-If you like this plugin and find it useful, I would be forever grateful for your support:
+# homebridge-kobold
 
-<a href="https://www.buymeacoffee.com/naofireblade" target="_blank"><img width="140" src="https://bmc-cdn.nyc3.digitaloceanspaces.com/BMC-button-images/custom_images/orange_img.png" alt="Buy Me A Coffee"></a>
+This is a plugin for [homebridge](https://github.com/nfarina/homebridge) to control your [Vorwerk Kobold](https://kobold.vorwerk.de/saugroboter/) VR300 vacuum robot. You can download it via [npm](https://www.npmjs.com/package/homebridge-kobold).
 
-Feel free to leave any feedback [here](https://github.com/naofireblade/homebridge-neato/issues).
+It is based on a fork of naofireblade's [homebridge-neato](https://github.com/naofireblade/homebridge-neato), merged with the oAuth authentication mechanism from nicoh88's [homebridge-vorwerk](https://github.com/nicoh88/homebridge-vorwerk).
+
+The interaction with the Server is handled by the underlying [node-kobold-control](https://github.com/himbeles/node-kobold-control) module.
 
 ## Features
 
@@ -17,10 +16,10 @@ Feel free to leave any feedback [here](https://github.com/naofireblade/homebridg
   - Eco mode
   - Extra care navigation
   - Nogo lines
-- Zone cleaning <sup>[1](#d7)</sup><sup>, </sup><sup>[2](#change-room)</sup>
+- Zone cleaning <sup>[1](#change-room)</sup>
 - Spot cleaning
-  - Individual spot size <sup>[1](#d7)</sup><sup>, </sup><sup>[3](#eve)</sup>
+  - Individual spot size <sup>[2](#eve)</sup>
-  - Clean twice <sup>[3](#eve)</sup>
+  - Clean twice <sup>[2](#eve)</sup>
 - Return to dock
 - Find the robot
 - Schedule (de)activation
@@ -31,9 +30,8 @@ Feel free to leave any feedback [here](https://github.com/naofireblade/homebridg
   - Model and firmware version
 - Automatic or periodic refresh of robot state
 - Multiple robots
-- Multiple language support (en, de, fr)
 
-> <b name="d7">1</b> Only available on the Neato D7.  
+- German, English or French Language Setting
 
 > <b name="change-room">2</b> You can send the robot from one room to another as well. He will return to the base, wait there some seconds and then starts cleaning the next room.
 
@@ -44,27 +42,65 @@ Feel free to leave any feedback [here](https://github.com/naofireblade/homebridg
 ## Installation
 
 1. Install homebridge using: `npm install -g homebridge`
-2. Install this plugin using: `npm install -g homebridge-neato`
+2. Install this plugin using: `npm install -g homebridge-kobold`
-3. If you don't have a Neato account yet, create one [here](https://www.neatorobotics.com/create-account/).
+3. Update your configuration file. See the sample below.
-4. Update your configuration file. See the sample below.
 
 ## Configuration
 
-Add the following information to your config file. Change the values for email and password.
+Add the following information to your config file. Adapt the value for `token`.
 
 ### Simple
 
 ```json
 "platforms": [
   {
-		"platform": "NeatoVacuumRobot",
+    "platform": "KoboldVacuumRobot",
-		"email": "YourEmail",
+    "token": "YourToken",
-		"password": "YourPassword",
     "language": "de"
   }
 ]
 ```
 
+You can get a token using the GUI tool [Kobold Token Getter](https://github.com/himbeles/kobold-token-get) or using the following two curl commands:
+
+```bash
+# This will trigger the email sending
+curl -X "POST" "https://mykobold.eu.auth0.com/passwordless/start" \
+     -H 'Content-Type: application/json' \
+     -d '{
+  "send": "code",
+  "email": "ENTER_YOUR_EMAIL_HERE",
+  "client_id": "KY4YbVAvtgB7lp8vIbWQ7zLk3hssZlhR",
+  "connection": "email"
+}'
+```
+==== wait for the email to be received ====
+
+```bash
+# this will generate a token using the numbers you received via email
+# replace the value of otp 123456 with the value you received from the email
+curl -X "POST" "https://mykobold.eu.auth0.com/oauth/token" \
+     -H 'Content-Type: application/json' \
+     -d '{
+  "prompt": "login",
+  "grant_type": "http://auth0.com/oauth/grant-type/passwordless/otp",
+  "scope": "openid email profile read:current_user",
+  "locale": "en",
+  "otp": "123456",
+  "source": "vorwerk_auth0",
+  "platform": "ios",
+  "audience": "https://mykobold.eu.auth0.com/userinfo",
+  "username": "ENTER_YOUR_EMAIL_HERE",
+  "client_id": "KY4YbVAvtgB7lp8vIbWQ7zLk3hssZlhR",
+  "realm": "email",
+  "country_code": "DE"
+}'
+```
+
+From the output, you want to copy the `id_token` value.
+
+The `language` can be `de` for German, `en` for English, or `fr` for French.
+
 ### Advanced
 
 Below are explanations for advanced parameters to adjust the plugin to your needs. All parameters are *optional*.
@@ -81,23 +117,15 @@ List of plugin features that you don't want to use in homekit (e.g. `dock`, `doc
 ```json
 "platforms": [
   {
-		"platform": "NeatoVacuumRobot",
+    "platform": "KoboldVacuumRobot",
-		"email": "YourEmail",
+    "token": "YourToken",
-		"password": "YourPassword",
-		"language": "de",
     "refresh": "120",
-		"hidden": ["dock", "dockstate", "eco", "nogolines", "extracare", "schedule", "find", "spot"]
+    "hidden": ["dock", "dockstate", "eco", "nogolines", "extracare", "schedule", "find", "spot"],
+    "language": "de"
   }
 ]
 ```
 
 ## Tested robots
 
-The plugin is successfully tested with all Neato Connected Robots.
+- Vorwerk Kobold VR300
-
-## Contributors
-Many thanks go to
-- [ghulands](https://github.com/ghulands) for finding and fixing a bug when no robot is associated with the neato account
-- [Berkay](https://github.com/btutal) for adding the schema file to use the plugin with homebridge-config-ui-x
-- [Antoine de Maleprade](https://github.com/az0uz) for adding the zone cleaning feature
-- [DJay](https://github.com/DJay-X) for testing out tons of new beta versions

_config.yml

@@ -1 +0,0 @@
-theme: jekyll-theme-cayman

accessories/koboldVacuumRobot.js

@@ -1,4 +1,4 @@
-const debug = require('debug')('homebridge-neato');
+const debug = require('debug')('homebridge-kobold');
 const colors = require('colors');
 
 const CustomUUID = {
@@ -21,10 +21,10 @@ module.exports = function (_Service, _Characteristic)
 	SpotHeightCharacteristic = require('../characteristics/spotHeight')(Characteristic, CustomUUID);
 	SpotRepeatCharacteristic = require('../characteristics/spotRepeat')(Characteristic, CustomUUID);
 
-	return NeatoVacuumRobotAccessory;
+	return KoboldVacuumRobotAccessory;
 };
 
-function NeatoVacuumRobotAccessory(platform, robotObject)
+function KoboldVacuumRobotAccessory(platform, robotObject)
 {
 	this.platform = platform;
 	this.log = platform.log;
@@ -136,12 +136,13 @@ function NeatoVacuumRobotAccessory(platform, robotObject)
 			serviceName = this.dict["clean"] + " " + this.boundary.name;
 		}
 		this.cleanService = new Service.Switch(serviceName, "cleanBoundary:" + this.boundary.id);
+		this.cleanService = new Service.Switch(serviceName + "1", "cleanBoundary:" + this.boundary.id)
 	}
 
 	this.log("Added cleaning device named: " + this.name);
 }
 
-NeatoVacuumRobotAccessory.prototype = {
+KoboldVacuumRobotAccessory.prototype = {
 	identify: function (callback)
 	{
 		this.robot.getState((error, result) =>
@@ -163,7 +164,7 @@ NeatoVacuumRobotAccessory.prototype = {
 	{
 		this.informationService = new Service.AccessoryInformation();
 		this.informationService
-		.setCharacteristic(Characteristic.Manufacturer, "Neato Robotics")
+		.setCharacteristic(Characteristic.Manufacturer, "Vorwerk Deutschland Stiftung & Co. KG")
 		.setCharacteristic(Characteristic.Model, this.meta.modelName)
 		.setCharacteristic(Characteristic.SerialNumber, this.robot._serial)
 		.setCharacteristic(Characteristic.FirmwareRevision, this.meta.firmware)
@@ -281,6 +282,7 @@ NeatoVacuumRobotAccessory.prototype = {
 					// Start cleaning
 					else if (this.robot.canStart)
 					{
+						debug(this.name + ": ## Start cleaning");
 						this.clean(callback);
 					}
 					// Cannot start

config.schema.json

@@ -1,22 +1,15 @@
 {
-    "pluginAlias": "NeatoVacuumRobot",
+    "pluginAlias": "KoboldVacuumRobot",
     "pluginType": "platform",
-    "headerDisplay": "For Advanced settings like Refresh time interval or Disabled switches/sensors. [Check Here](https://github.com/naofireblade/homebridge-neato#readme)",
+    "headerDisplay": "For Advanced settings like the refresh time interval or disabled switches/sensors. [Check Here](https://github.com/himbeles/homebridge-kobold#readme)",
     "schema": {
       "type": "object",
       "properties": {
-        "email": {
+        "token": {
-          "title": "email",
+            "title": "token",
             "type": "string",
             "required": true,
-          "format": "email",
+            "description": "Your Kobold Token (https://git.io/J3g1b)"
-          "description": "Your Email Address"
-        },
-        "password": {
-            "title": "password",
-            "type": "string",
-            "required": true,
-            "description": "Your Password"
         },
         "language": {
           "title": "language",

index.js

@@ -1,26 +1,25 @@
 "use strict";
 let inherits = require('util').inherits,
-	debug = require('debug')('homebridge-neato'),
+	debug = require('debug')('homebridge-kobold'),
-	botvac = require('node-botvac'),
+	control = require('node-kobold-control'),
 
 	Service,
 	Characteristic,
-	NeatoVacuumRobotAccessory;
+	KoboldVacuumRobotAccessory;
 
 module.exports = function (homebridge)
 {
 	Service = homebridge.hap.Service;
 	Characteristic = homebridge.hap.Characteristic;
-	NeatoVacuumRobotAccessory = require('./accessories/neatoVacuumRobot')(Service, Characteristic);
+	KoboldVacuumRobotAccessory = require('./accessories/koboldVacuumRobot')(Service, Characteristic);
-	homebridge.registerPlatform("homebridge-neato", "NeatoVacuumRobot", NeatoVacuumRobotPlatform);
+	homebridge.registerPlatform("homebridge-kobold", "KoboldVacuumRobot", KoboldVacuumRobotPlatform);
 };
 
-function NeatoVacuumRobotPlatform(log, config)
+function KoboldVacuumRobotPlatform(log, config)
 {
 	this.log = log;
 	this.serial = "1-3-3-7";
-	this.email = config['email'];
+	this.token = config['token'];
-	this.password = config['password'];
 	this.language = config['language'];
 	this.hiddenServices = '';
 	this.hiddenServices = ('disabled' in config ? config['disabled'] : this.hiddenServices);
@@ -36,10 +35,10 @@ function NeatoVacuumRobotPlatform(log, config)
 		this.refresh = parseInt(config['refresh']);
 		// must be integer and positive
 		this.refresh = (typeof this.refresh !== 'number' || (this.refresh % 1) !== 0 || this.refresh < 0) ? 60 : this.refresh;
-		// minimum 60s to save some load on the neato servers
+		// minimum 60s to save some load on the Vorwerk servers
 		if (this.refresh > 0 && this.refresh < 60)
 		{
-			this.log.warn("Minimum refresh time is 60 seconds to not overload the neato servers");
+			this.log.warn("Minimum refresh time is 60 seconds to not overload the Vorwerk servers");
 			this.refresh = (this.refresh > 0 && this.refresh < 60) ? 60 : this.refresh;
 		}
 	}
@@ -51,7 +50,7 @@ function NeatoVacuumRobotPlatform(log, config)
 	this.log("Refresh is set to: " + this.refresh + (this.refresh !== 'auto' ? ' seconds' : ''));
 }
 
-NeatoVacuumRobotPlatform.prototype = {
+KoboldVacuumRobotPlatform.prototype = {
 	accessories: function (callback)
 	{
 		debug("Get robots");
@@ -61,8 +60,8 @@ NeatoVacuumRobotPlatform.prototype = {
 		this.getRobots(() =>
 		{
 			// // MOCK MULTIPLE ROBOTS START
-			// let client = new botvac.Client();
+			// let client = new control.Client();
-			// client.authorize(this.email, this.password, false, (error) =>
+			// client.authorize(this.token, (error) =>
 			// {
 			// 	client.getRobots((error, robs) =>
 			// 	{
@@ -77,7 +76,7 @@ NeatoVacuumRobotPlatform.prototype = {
 						{
 							this.log("Found robot #" + (i + 1) + " named \"" + robot.device.name + "\" with serial \"" + robot.device._serial.substring(0, 9) + "XXXXXXXXXXXX\"");
 
-							let mainAccessory = new NeatoVacuumRobotAccessory(this, robot);
+							let mainAccessory = new KoboldVacuumRobotAccessory(this, robot);
 							accessories.push(mainAccessory);
 
 							robot.mainAccessory = mainAccessory;
@@ -88,7 +87,7 @@ NeatoVacuumRobotPlatform.prototype = {
 
 							// // MOCK ZONE CLEANING START
 							// robot.boundary = {name: "Testroom", id: "1"};
-							// let roomAccessory = new NeatoVacuumRobotAccessory(this, robot);
+							// let roomAccessory = new KoboldVacuumRobotAccessory(this, robot);
 							// accessories.push(roomAccessory);
 							// robot.roomAccessories.push(roomAccessory);
 							// // MOCK ZONE CLEANING END
@@ -104,7 +103,7 @@ NeatoVacuumRobotPlatform.prototype = {
 											if (boundary.type === "polygon")
 											{
 												robot.boundary = boundary;
-												let roomAccessory = new NeatoVacuumRobotAccessory(this, robot);
+												let roomAccessory = new KoboldVacuumRobotAccessory(this, robot);
 												accessories.push(roomAccessory);
 
 												robot.roomAccessories.push(roomAccessory);
@@ -127,14 +126,14 @@ NeatoVacuumRobotPlatform.prototype = {
 	getRobots: function (callback)
 	{
 		debug("Loading your robots");
-		let client = new botvac.Client();
+		let client = new control.Client();
 
 		// Login
-		client.authorize(this.email, this.password, false, (error) =>
+		client.authorize(this.token, (error) =>
 		{
 			if (error)
 			{
-				this.log.error("Can't log on to neato cloud. Please check your internet connection and your credentials. Try again later if the neato servers have issues: " + error);
+				this.log.error("Can't log on to Vorwerk cloud. Please check your internet connection and your token. Try again later if the Vorwerk servers have issues: " + error);
 				callback();
 			}
 			else
@@ -144,7 +143,7 @@ NeatoVacuumRobotPlatform.prototype = {
 				{
 					if (error)
 					{
-						this.log.error("Successful login but can't connect to your neato robot: " + error);
+						this.log.error("Successful login but can't connect to your Vorwerk robot: " + error);
 						callback();
 					}
 					else if (robots.length === 0)

package.json

@@ -1,43 +1,35 @@
 {
-  "name": "homebridge-neato",
+  "name": "homebridge-kobold",
-  "version": "0.7.3",
+  "version": "0.8.4",
-  "description": "A Neato vacuum robot plugin for homebridge.",
+  "description": "A Vorwerk Kobold vacuum robot plugin for homebridge.",
   "license": "MIT",
   "keywords": [
     "homebridge-plugin",
-    "neato",
+    "vorwerk",
-    "botvac"
+    "kobold"
   ],
   "engines": {
     "node": ">=0.12.0",
     "homebridge": ">=0.2.0"
   },
   "author": {
-    "name": "Arne Blumentritt",
+    "name": "Luis R.",
-    "url2": "https://github.com/naofireblade"
+    "url2": "https://github.com/himbeles"
   },
   "contributors": [
     {
-      "name": "ghulands",
+      "name": "Alexandre L.",
-      "url": "https://github.com/ghulands"
+      "url": "https://github.com/aluini"
-    },
-    {
-      "name": "Berkay",
-      "url": "https://github.com/btutal"
-    },
-    {
-      "name": "Antoine de Maleprade",
-      "url": "https://github.com/az0uz"
     }
   ],
   "repository": {
     "type": "git",
-    "url": "git://github.com/naofireblade/homebridge-neato.git"
+    "url": "git://github.com/himbeles/homebridge-kobold.git"
   },
   "dependencies": {
     "colors": "^1.4.0",
     "debug": "^4.1.1",
-    "node-botvac": ">=0.4.0",
+    "node-kobold-control": ">=0.4.2",
     "uuid": "^3.3.2"
   }
 }