From 9c021a5226e06c9fe194a1a243cb0c2abb3f042c Mon Sep 17 00:00:00 2001 From: Fuempel <37498706+Fuempel@users.noreply.github.com> Date: Sun, 19 Jun 2022 16:41:38 +0200 Subject: [PATCH] Review findings correction for zone cleaning support --- manifest.json | 7 ++++--- vacuum.py | 22 ---------------------- 2 files changed, 4 insertions(+), 25 deletions(-) diff --git a/manifest.json b/manifest.json index 4345700..ebe7529 100644 --- a/manifest.json +++ b/manifest.json @@ -2,16 +2,17 @@ "domain": "vorwerk", "name": "Vorwerk Kobold", "config_flow": true, - "documentation": "https://www.home-assistant.io/integrations/vorwerk", + "documentation": "https://github.com/trunneml/homeassistant-vorwerk", "requirements": [ "pybotvac==0.0.23" ], "codeowners": [ - "@trunneml" + "@trunneml", + "@fuempel" ], "dependencies": [ "http" ], "iot_class": "cloud_polling", - "version": "0.9.6" + "version": "0.10.0" } \ No newline at end of file diff --git a/vacuum.py b/vacuum.py index 9634fd0..542749a 100644 --- a/vacuum.py +++ b/vacuum.py @@ -104,7 +104,6 @@ class VorwerkConnectedVacuum(CoordinatorEntity, StateVacuumEntity): self._name = f"{self.robot.name}" self._robot_serial = self.robot.serial - self._robot_boundaries: list[str] = [] self._token = token @property @@ -284,24 +283,3 @@ class VorwerkConnectedVacuum(CoordinatorEntity, StateVacuumEntity): _LOGGER.error( "Vorwerk vacuum connection error for '%s': %s", self.entity_id, ex ) - - - # TODO: OLD CODE -# boundary_id = None -# if zone is not None: -# for boundary in self._robot_boundaries: -# if zone in boundary["name"]: -# boundary_id = boundary["id"] -# if boundary_id is None: -# _LOGGER.error( -# "Zone '%s' was not found for the robot '%s'", zone, self.entity_id -# ) -# return -# _LOGGER.info("Start cleaning zone '%s' with robot %s", zone, self.entity_id) - -# try: -# self.robot.start_cleaning(mode, navigation, category, boundary_id) -# except NeatoRobotException as ex: -# _LOGGER.error( -# "Vorwerk vacuum connection error for '%s': %s", self.entity_id, ex -# )