From 7a0a3589a548bba5749fc26455b13127cd7cdd0b Mon Sep 17 00:00:00 2001 From: Fleischer Hanno Date: Sun, 1 Dec 2024 22:14:09 +0100 Subject: [PATCH 1/4] trying to fix server ip to use outward ip --- .../src/main/java/pp/mdga/client/ModelSynchronizer.java | 4 +--- .../src/main/java/pp/mdga/client/server/MdgaServer.java | 5 +++++ .../client/src/main/java/pp/mdga/client/view/MainView.java | 6 +----- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/Projekte/mdga/client/src/main/java/pp/mdga/client/ModelSynchronizer.java b/Projekte/mdga/client/src/main/java/pp/mdga/client/ModelSynchronizer.java index 950dfaa6..1ca3cca5 100644 --- a/Projekte/mdga/client/src/main/java/pp/mdga/client/ModelSynchronizer.java +++ b/Projekte/mdga/client/src/main/java/pp/mdga/client/ModelSynchronizer.java @@ -130,9 +130,7 @@ public void setJoin(String ip, int port) { } public void leave() { - LOGGER.log(Level.INFO, "leave"); - app.getAcousticHandler().playSound(MdgaSound.LEAVE); - enter(MdgaState.MAIN); + app.getGameLogic().selectLeave(); } public void enter(MdgaState state) { diff --git a/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java b/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java index f63de56a..3522d1e7 100644 --- a/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java +++ b/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java @@ -14,6 +14,7 @@ import java.io.IOException; import java.lang.System.Logger; import java.lang.System.Logger.Level; +import java.net.InetAddress; import java.util.Map; import java.util.UUID; import java.util.concurrent.BlockingQueue; @@ -67,6 +68,9 @@ public void run() { private void startServer() { try { LOGGER.log(Level.INFO, "Starting server..."); //NON-NLS + InetAddress localhost; + localhost = InetAddress.getLocalHost(); + String ip = localhost.getHostAddress(); myServer = Network.createServer(port); initializeSerializables(); myServer.start(); @@ -190,6 +194,7 @@ private void messageReceived(HostedConnection source, ClientMessage message) { @Override public void connectionAdded(Server server, HostedConnection hostedConnection) { + System.out.println("new connection " + hostedConnection); //NON-NLS LOGGER.log(Level.DEBUG, "new connection {0}", hostedConnection); //NON-NLS } diff --git a/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java b/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java index 6aa5161d..dc5076b5 100644 --- a/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java +++ b/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java @@ -102,7 +102,6 @@ private void tryHost() { if(port >= 1 && port <= 65535) { app.getModelSynchronize().setName(startDialog.getName()); - hostDialog.setHostname(Inet4Address.getLocalHost().getHostAddress()); hostDialog.hostServer(); try { Thread.sleep(1000); @@ -117,10 +116,7 @@ private void tryHost() { //app.getAcousticHandler().playSound(MdgaSound.WRONG_INPUT); return; } - } catch (NumberFormatException e) { - //nothing - } catch (UnknownHostException e) { - throw new RuntimeException(e); + } catch (NumberFormatException ignored) { } hostDialog.resetPort(); From 92be52b62a094986f58142b0fa4731d8df6385a7 Mon Sep 17 00:00:00 2001 From: Fleischer Hanno Date: Sun, 1 Dec 2024 22:33:30 +0100 Subject: [PATCH 2/4] fixed server join logic --- .../src/main/java/pp/mdga/client/server/MdgaServer.java | 4 +--- .../client/src/main/java/pp/mdga/client/view/MainView.java | 7 ++++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java b/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java index 3522d1e7..8a952a12 100644 --- a/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java +++ b/Projekte/mdga/client/src/main/java/pp/mdga/client/server/MdgaServer.java @@ -68,9 +68,7 @@ public void run() { private void startServer() { try { LOGGER.log(Level.INFO, "Starting server..."); //NON-NLS - InetAddress localhost; - localhost = InetAddress.getLocalHost(); - String ip = localhost.getHostAddress(); + myServer = Network.createServer(port); initializeSerializables(); myServer.start(); diff --git a/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java b/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java index dc5076b5..68416fa3 100644 --- a/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java +++ b/Projekte/mdga/client/src/main/java/pp/mdga/client/view/MainView.java @@ -126,7 +126,7 @@ private void tryHost() { private void tryJoin() { int port = 0; String ip = joinDialog.getIpt(); - String portText = hostDialog.getPort(); + String portText = joinDialog.getPort(); try { // Validate the port @@ -134,9 +134,10 @@ private void tryJoin() { if (port < 1 || port > 65535) { throw new IllegalArgumentException("Invalid port"); } - + joinDialog.setPortNumber(port); // Validate the IP address if (isValidIpAddress(ip)) { + joinDialog.setHostname(ip); app.getModelSynchronize().setName(startDialog.getName()); app.getModelSynchronize().setJoin(ip, port); joinDialog.connectToServer(); @@ -146,7 +147,7 @@ private void tryJoin() { // Invalid input, fall through to reset } - hostDialog.resetPort(); + joinDialog.resetPort(); joinDialog.resetIp(); app.getAcousticHandler().playSound(MdgaSound.WRONG_INPUT); } From eaf46f3e14d5a929bd1e0b4361469542cdcca9a2 Mon Sep 17 00:00:00 2001 From: Daniel Grigencha Date: Sun, 1 Dec 2024 22:37:49 +0100 Subject: [PATCH 3/4] updated the project to pass the checkstyle --- Projekte/.run/MdgaApp.run.xml | 4 +- .../src/main/java/pp/mdga/client/Asset.java | 8 +- .../pp/mdga/client/acoustic/MusicAsset.java | 6 +- .../client/board/Outline/OutlineFilter.java | 79 --------- .../board/Outline/OutlinePreFilter.java | 67 -------- .../board/Outline/OutlineProFilter.java | 79 --------- .../board/Outline/SelectObjectOutliner.java | 88 ---------- .../pp/mdga/client/board/OutlineControl.java | 2 +- .../pp/mdga/client/button/ClickButton.java | 10 +- .../java/pp/mdga/client/dialog/Dialog.java | 3 +- .../pp/mdga/client/dialog/NetworkDialog.java | 1 + .../java/pp/mdga/client/gui/CardLayer.java | 28 ++-- .../pp/mdga/client/gui/SymbolControl.java | 40 ++--- .../java/pp/mdga/client/gui/ZoomControl.java | 16 +- .../pp/mdga/client/server/MdgaServer.java | 6 +- .../java/pp/mdga/client/view/MainView.java | 2 + .../java/pp/mdga/client/view/MdgaView.java | 18 +- .../java/pp/mdga/client/CeremonyState.java | 7 +- .../java/pp/mdga/client/DialogsState.java | 8 +- .../main/java/pp/mdga/client/GameState.java | 2 +- .../java/pp/mdga/client/SettingsState.java | 8 +- .../client/ceremonyState/CeremonyStates.java | 10 -- .../client/ceremonyState/PodiumState.java | 30 ---- .../client/ceremonyState/StatisticsState.java | 25 --- .../mdga/client/dialogState/DialogStates.java | 11 -- .../mdga/client/dialogState/LobbyState.java | 102 ------------ .../dialogState/NetworkDialogState.java | 62 ------- .../client/dialogState/StartDialogState.java | 50 ------ .../mdga/client/gameState/AnimationState.java | 32 ---- .../gameState/DetermineStartPlayerState.java | 77 --------- .../pp/mdga/client/gameState/GameStates.java | 51 ------ .../mdga/client/gameState/SpectatorState.java | 84 ---------- .../pp/mdga/client/gameState/TurnState.java | 155 ------------------ .../mdga/client/gameState/WaitingState.java | 97 ----------- .../DetermineStartPlayerStates.java | 12 -- .../RollRankingDiceState.java | 38 ----- .../WaitRankingState.java | 40 ----- .../gameState/turnState/ChoosePieceState.java | 95 ----------- .../gameState/turnState/MovePieceState.java | 56 ------- .../turnState/PlayPowerCardState.java | 41 ----- .../gameState/turnState/PowerCardState.java | 97 ----------- .../gameState/turnState/RollDiceState.java | 41 ----- .../gameState/turnState/TurnStates.java | 11 -- .../choosePieceState/ChoosePieceStates.java | 11 -- .../choosePieceState/NoPieceState.java | 68 -------- .../choosePieceState/SelectPieceState.java | 62 ------- .../choosePieceState/StartPieceState.java | 42 ----- .../choosePieceState/WaitingPieceState.java | 43 ----- .../powerCardState/ChoosePowerCardState.java | 113 ------------- .../powerCardState/PowerCardStates.java | 11 -- .../turnState/powerCardState/ShieldState.java | 54 ------ .../turnState/powerCardState/SwapState.java | 68 -------- .../settingsState/AudioSettingsState.java | 20 --- .../settingsState/MainSettingsState.java | 20 --- .../client/settingsState/SettingStates.java | 10 -- .../settingsState/VideoSettingsState.java | 20 --- .../java/pp/mdga/server/ServerGameLogic.java | 8 +- .../game/turn/rolldice/FirstRollState.java | 31 ++++ .../turn/rolldice/FirstRollStateState.java | 7 - 59 files changed, 122 insertions(+), 2165 deletions(-) delete mode 100644 Projekte/mdga/client/src/main/java/pp/mdga/client/board/Outline/OutlineFilter.java delete mode 100644 Projekte/mdga/client/src/main/java/pp/mdga/client/board/Outline/OutlinePreFilter.java delete mode 100644 Projekte/mdga/client/src/main/java/pp/mdga/client/board/Outline/OutlineProFilter.java delete mode 100644 Projekte/mdga/client/src/main/java/pp/mdga/client/board/Outline/SelectObjectOutliner.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/ceremonyState/CeremonyStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/ceremonyState/PodiumState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/ceremonyState/StatisticsState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/dialogState/DialogStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/dialogState/LobbyState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/dialogState/NetworkDialogState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/dialogState/StartDialogState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/AnimationState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/DetermineStartPlayerState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/GameStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/SpectatorState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/TurnState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/WaitingState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/determineStartPlayerState/DetermineStartPlayerStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/determineStartPlayerState/RollRankingDiceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/determineStartPlayerState/WaitRankingState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/ChoosePieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/MovePieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/PlayPowerCardState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/PowerCardState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/RollDiceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/TurnStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/choosePieceState/ChoosePieceStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/choosePieceState/NoPieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/choosePieceState/SelectPieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/choosePieceState/StartPieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/choosePieceState/WaitingPieceState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/powerCardState/ChoosePowerCardState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/powerCardState/PowerCardStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/powerCardState/ShieldState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/gameState/turnState/powerCardState/SwapState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/settingsState/AudioSettingsState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/settingsState/MainSettingsState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/settingsState/SettingStates.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/client/settingsState/VideoSettingsState.java create mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/server/automaton/game/turn/rolldice/FirstRollState.java delete mode 100644 Projekte/mdga/model/src/main/java/pp/mdga/server/automaton/game/turn/rolldice/FirstRollStateState.java diff --git a/Projekte/.run/MdgaApp.run.xml b/Projekte/.run/MdgaApp.run.xml index 82e2f2b6..8b467373 100644 --- a/Projekte/.run/MdgaApp.run.xml +++ b/Projekte/.run/MdgaApp.run.xml @@ -6,7 +6,7 @@