accepted review comments

This commit is contained in:
J-Klinke
2024-07-04 18:28:44 +02:00
parent 62b0d5c028
commit bbb8c9259f
3 changed files with 10 additions and 11 deletions

View File

@@ -24,9 +24,8 @@ function parseContent(content, clearResults) {
Array.from(searchSection.querySelectorAll(".datasets .dataset")).forEach(e => e.remove());
}
for (const dataset of datasets) {
console.log(dataset) //TODO: remove
searchSection.querySelector(".datasets")
.appendChild(dataset.createDatasetHTMLElement(dataset.getID()));
.appendChild(dataset.createDatasetHTMLElement());
}
}
}

View File

@@ -1,4 +1,4 @@
import { vote, votedIDs } from "./main.js";
import { vote } from "./main.js";
export default class Dataset {
#abstract;
@@ -29,20 +29,20 @@ export default class Dataset {
this.#votes = votes;
}
createDatasetHTMLElement(entryID) {
createDatasetHTMLElement() {
let template = document.querySelector("#dataset-template");
const clone = template.content.cloneNode(true);
clone.querySelector(".dataset").dataset.id = this.#id;
clone.querySelector("h3").innerText = this.#title;
clone.querySelector("p").innerText = this.#description;
clone.querySelector("span").innerText = this.#upvotes;
let votedIDs = window.localStorage;
// depending on whether the button has been up/downvoted, its according button get disabled and hidden
if (votedIDs.getItem(entryID)) {
let votedButton = clone.querySelector(votedIDs.getItem(entryID)? ".upvote-btn":".downvote-btn");
if (votedIDs.getItem(this.#id)) {
let votedButton = clone.querySelector(votedIDs.getItem(this.#id)? ".upvote-btn":".downvote-btn");
votedButton.classList.add("isVoted");
votedButton.disabled = true;
let notVotedButton = clone.querySelector(votedIDs.getItem(entryID)? ".downvote-btn":".upvote-btn");
let notVotedButton = clone.querySelector(votedIDs.getItem(this.#id)? ".downvote-btn":".upvote-btn");
notVotedButton.style.visibility = "hidden";
}

View File

@@ -8,7 +8,7 @@ export const lastQuery = {
totalPages: 0,
currentPage: 0
};
export const votedIDs = window.sessionStorage;
const votedIDs = window.localStorage;
// definition of all buttons & sections
const addButton = document.getElementById("add-btn");
@@ -202,7 +202,7 @@ function fetchInitialEntries() {
const datasets = data.content.map(dataset => new Dataset(dataset));
for (const dataset of datasets) {
document.querySelector("#recents .datasets")
.appendChild(dataset.createDatasetHTMLElement(dataset.getID()));
.appendChild(dataset.createDatasetHTMLElement());
}
});
@@ -215,7 +215,7 @@ function fetchInitialEntries() {
.then((data) => {
let dataset = new Dataset(data.content[0]);
document.querySelector("#top .datasets")
.appendChild(dataset.createDatasetHTMLElement(dataset.getID()));
.appendChild(dataset.createDatasetHTMLElement());
});
}